netdev - Re: [RFC 0/3] ptp: Add esterror support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr2BDLnmIHCrceze@hoboy.vegasvil.org>
Date: Wed, 14 Aug 2024 21:16:12 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Miroslav Lichvar <mlichvar@...hat.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Maciek Machnikowski <maciek@...hnikowski.net>,
	netdev@...r.kernel.org, jacob.e.keller@...el.com,
	darinzon@...zon.com, kuba@...nel.org
Subject: Re: [RFC 0/3] ptp: Add esterror support

On Wed, Aug 14, 2024 at 08:33:26PM -0700, Richard Cochran wrote:
> On Wed, Aug 14, 2024 at 03:08:07PM +0200, Andrew Lunn wrote:
> 
> > So the driver itself does not know its own error? It has to be told
> > it, so it can report it back to user space. Then why bother, just put
> > it directly into the ptp4l configuration file?
> 
> This way my first reaction as well.

Actually, looking at the NTP code, we have:

void process_adjtimex_modes(const struct __kernel_timex *txc,)
{
	...
	if (txc->modes & ADJ_ESTERROR)
		time_esterror = txc->esterror;
	...
}

So I guess PHCs should also support setting this from user space?

adding CC: Miroslav

At least it would be consistent.


Thanks,
Richard