netdev - Re: [RFC 1/3] ptp: Implement timex esterror support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr2Cun2AhVLRAm1t@hoboy.vegasvil.org>
Date: Wed, 14 Aug 2024 21:23:22 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Maciek Machnikowski <maciek@...hnikowski.net>
Cc: netdev@...r.kernel.org, jacob.e.keller@...el.com, vadfed@...a.com,
	darinzon@...zon.com, kuba@...nel.org
Subject: Re: [RFC 1/3] ptp: Implement timex esterror support

On Tue, Aug 13, 2024 at 12:56:00PM +0000, Maciek Machnikowski wrote:
> The Timex structure returned by the clock_adjtime() POSIX API allows
> the clock to return the estimated error. Implement getesterror
> and setesterror functions in the ptp_clock_info to enable drivers
> to interact with the hardware to get the error information.

So this can be implemented in the PTP class layer directly.  No need
for driver callbacks.
 
> getesterror additionally implements returning hw_ts and sys_ts
> to enable upper layers to estimate the maximum error of the clock
> based on the last time of correction.

But where are the upper layers?

> This functionality is not
> directly implemented in the clock_adjtime and will require
> a separate interface in the future.

We don't add interfaces that have no users.

Thanks,
Richard