netdev - Re: [PATCH iwl-next v6 1/6] igb: Always call igb_xdp_ring_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmkgu6y9.fsf@kurt.kurt.home>
Date: Fri, 16 Aug 2024 11:56:30 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
 <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Richard
 Cochran <richardcochran@...il.com>, Sriram Yagnaraman
 <sriram.yagnaraman@...csson.com>, Benjamin Steinke
 <benjamin.steinke@...s-audio.com>, Maciej Fijalkowski
 <maciej.fijalkowski@...el.com>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, bpf@...r.kernel.org, Sriram Yagnaraman
 <sriram.yagnaraman@....tech>
Subject: Re: [PATCH iwl-next v6 1/6] igb: Always call
 igb_xdp_ring_update_tail() under Tx lock

On Fri Aug 16 2024, Sebastian Andrzej Siewior wrote:
> On 2024-08-16 11:24:00 [+0200], Kurt Kanzenbach wrote:
>> index 11be39f435f3..4d5e5691c9bd 100644
>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>> @@ -2914,6 +2914,7 @@ static int igb_xdp(struct net_device *dev, struct netdev_bpf *xdp)
>>  	}
>>  }
>>  
>> +/* This function assumes __netif_tx_lock is held by the caller. */
>>  static void igb_xdp_ring_update_tail(struct igb_ring *ring)
>>  {
>>  	/* Force memory writes to complete before letting h/w know there
> This
>   lockdep_assert_held(txring_txq(ring)->_xmit_lock);
> would be more powerful than the comment ;)

Probably yes :-).

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)