netdev - Re: [PATCH net v3 1/2] ptp: ocp: adjust sysfs entries to expose tty information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408161934.aQsUDy88-lkp@intel.com>
Date: Fri, 16 Aug 2024 20:03:06 +0800
From: kernel test robot <lkp@...el.com>
To: Vadim Fedorenko <vadfed@...a.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Jakub Kicinski <kuba@...nel.org>,
	Jonathan Lemon <jonathan.lemon@...il.com>,
	Jiri Slaby <jirislaby@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH net v3 1/2] ptp: ocp: adjust sysfs entries to expose tty
 information

Hi Vadim,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/docs-ABI-update-OCP-TimeCard-sysfs-entries/20240815-210131
base:   net/main
patch link:    https://lore.kernel.org/r/20240815125905.1667148-1-vadfed%40meta.com
patch subject: [PATCH net v3 1/2] ptp: ocp: adjust sysfs entries to expose tty information
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240816/202408161934.aQsUDy88-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240816/202408161934.aQsUDy88-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408161934.aQsUDy88-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_tty_show':
>> drivers/ptp/ptp_ocp.c:3360:37: warning: unused variable 'port' [-Wunused-variable]
    3360 |         struct ptp_ocp_serial_port *port;
         |                                     ^~~~


vim +/port +3360 drivers/ptp/ptp_ocp.c

  3354	
  3355	static ssize_t
  3356	ptp_ocp_tty_show(struct device *dev, struct device_attribute *attr, char *buf)
  3357	{
  3358		struct dev_ext_attribute *ea = to_ext_attr(attr);
  3359		struct ptp_ocp *bp = dev_get_drvdata(dev);
> 3360		struct ptp_ocp_serial_port *port;
  3361	
  3362		return sysfs_emit(buf, "ttyS%d", bp->port[(uintptr_t)ea->var].line);
  3363	}
  3364	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki