netdev - Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66bf5e76d36cf_1341d52942a@willemb.c.googlers.com.notmuch>
Date: Fri, 16 Aug 2024 10:13:10 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Felix Fietkau <nbd@....name>, 
 netdev@...r.kernel.org
Subject: Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO_SOFTWARE

Felix Fietkau wrote:
> Several drivers set NETIF_F_GSO_SOFTWARE, but mangle fraglist GRO packets
> in a way that they can't be properly segmented anymore.

Can you share a bit more concrete detail: which driver, for instance, and
how does it mangle the packet?

I assume something with inserting or deleting tunnel headers. But the
fraglist skbs should be able to reproduce the modified header in
skb_segment_list?

> In order to properly deal with this, remove fraglist GSO from
> NETIF_F_GSO_SOFTWARE and switch to NETIF_F_GSO_SOFTWARE_ALL (which includes
> fraglist GSO) in places where it's safe to add.
> 
> Signed-off-by: Felix Fietkau <nbd@....name>