netdev - Re: [PATCH v1 net] mctp: Use __mctp_dev_get() in mctp_fill_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240815183946.342e9952@kernel.org>
Date: Thu, 15 Aug 2024 18:39:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: Jeremy Kerr <jk@...econstruct.com.au>, Matt Johnston
 <matt@...econstruct.com.au>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Kuniyuki
 Iwashima <kuni1840@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net] mctp: Use __mctp_dev_get() in
 mctp_fill_link_af().

On Thu, 15 Aug 2024 13:42:54 -0700 Kuniyuki Iwashima wrote:
> Since commit 5fa85a09390c ("net: core: rcu-ify rtnl af_ops"),
> af_ops->fill_link_af() is called under RCU.
> 
> mctp_fill_link_af() calls mctp_dev_get_rtnl() that uses
> rtnl_dereference(), so lockdep should complain about it.
> 
> Let's use __mctp_dev_get() instead.

And this is what crashes kunit tests, I reckon.
-- 
pw-bot: cr