| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <pajh2btfch2a5nmjuup4djtv4l3ofref5tjx7ocs7ofwnjfej6@n3gf36v37liz> Date: Fri, 16 Aug 2024 21:46:07 +0300 From: Serge Semin <fancer.lancer@...il.com> To: jitendra.vegiraju@...adcom.com Cc: netdev@...r.kernel.org, alexandre.torgue@...s.st.com, joabreu@...opsys.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com, bcm-kernel-feedback-list@...adcom.com, richardcochran@...il.com, ast@...nel.org, daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com, rmk+kernel@...linux.org.uk, ahalaney@...hat.com, xiaolei.wang@...driver.com, rohan.g.thomas@...el.com, Jianheng.Zhang@...opsys.com, leong.ching.swee@...el.com, linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org, andrew@...n.ch, linux@...linux.org.uk, horms@...nel.org, florian.fainelli@...adcom.com Subject: Re: [net-next v4 0/5] net: stmmac: Add PCI driver support for BCM8958x Hi Jitendra On Wed, Aug 14, 2024 at 03:18:13PM -0700, jitendra.vegiraju@...adcom.com wrote: > From: Jitendra Vegiraju <jitendra.vegiraju@...adcom.com> > > This patchset adds basic PCI ethernet device driver support for Broadcom > BCM8958x Automotive Ethernet switch SoC devices. > > This SoC device has PCIe ethernet MAC attached to an integrated ethernet > switch using XGMII interface. The PCIe ethernet controller is presented to > the Linux host as PCI network device. > > The following block diagram gives an overview of the application. > +=================================+ > | Host CPU/Linux | > +=================================+ > || PCIe > || > +==========================================+ > | +--------------+ | > | | PCIE Endpoint| | > | | Ethernet | | > | | Controller | | > | | DMA | | > | +--------------+ | > | | MAC | BCM8958X | > | +--------------+ SoC | > | || XGMII | > | || | > | +--------------+ | > | | Ethernet | | > | | switch | | > | +--------------+ | > | || || || || | > +==========================================+ > || || || || More external interfaces > > The MAC block on BCM8958x is based on Synopsis XGMAC 4.00a core. This > MAC IP introduces new DMA architecture called Hyper-DMA for virtualization > scalability. > > Driver functionality specific to new MAC (DW25GMAC) is implemented in > new file dw25gmac.c. > > Management of integrated ethernet switch on this SoC is not handled by > the PCIe interface. > This SoC device has PCIe ethernet MAC directly attached to an integrated > ethernet switch using XGMII interface. > > v3->v4: > Based on Serge's questions, received a confirmation from Synopsis that > the MAC IP is indeed the new 25GMAC design. > Renamed all references of XGMAC4 to 25GMAC. > The patch series is rearranged slightly as follows. > Patch1 (new): Define HDMA mapping data structure in kernel's stmmac.h > Patch2 (v3 Patch1): Adds dma_ops for dw25gmac in stmmac core > Renamed new files dwxgmac4.* to dw25gmac.* - Serge Semin > Defined new Synopsis version and device id macros for DW25GMAC. > Coverted bit operations to FIELD_PREP macros - Russell King > Moved hwif.h to this patch, Sparse flagged warning - Simon Horman > Defined macros for hardcoded values TDPS etc - Serge Semin > Read number of PDMAs/VDMAs from hardware - Serge Semin > Patch3 (v3 Patch2): Hooks in hardware interface handling for dw25gmac > Resolved user_version quirks questions - Serge, Russell, Andrew > Added new stmmac_hw entry for DW25GMAC. - Serge > Added logic to override synopsis_dev_id by glue driver. > Patch4 (v3 Patch3): Adds PCI driver for BCM8958x device > Define bitmmap macros for hardcoded values - Andrew Lunn > Added per device software node - Andrew Lunn > Patch5(new/split): Adds BCM8958x driver to build system Thanks for the series update and I'm sorry for abandoning the v3 discussion. I had to work on another urgent task. I'll get back to reviewing your patch set on the next week. -Serge(y) > > v2->v3: > Addressed v2 comments from Andrew, Jakub, Russel and Simon. > Based on suggestion by Russel and Andrew, added software node to create > phylink in fixed-link mode. > Moved dwxgmac4 specific functions to new files dwxgmac4.c and dwxgmac4.h > in stmmac core module. > Reorganized the code to use the existing glue logic support for xgmac in > hwif.c and override ops functions for dwxgmac4 specific functions. > The patch is split into three parts. > Patch#1 Adds dma_ops for dwxgmac4 in stmmac core > Patch#2 Hooks in the hardware interface handling for dwxgmac4 > Patch#3 Adds PCI driver for BCM8958x device > https://lore.kernel.org/netdev/20240802031822.1862030-1-jitendra.vegiraju@broadcom.com/ > > v1->v2: > Minor fixes to address coding style issues. > Sent v2 too soon by mistake, without waiting for review comments. > Received feedback on this version. > https://lore.kernel.org/netdev/20240511015924.41457-1-jitendra.vegiraju@broadcom.com/ > > v1: > https://lore.kernel.org/netdev/20240510000331.154486-1-jitendra.vegiraju@broadcom.com/ > > Jitendra Vegiraju (5): > Add HDMA mapping for dw25gmac support > Add basic dw25gmac support to stmmac core > Integrate dw25gmac into stmmac hwif handling > Add PCI driver support for BCM8958x > Add BCM8958x driver to build system > > MAINTAINERS | 8 + > drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 + > drivers/net/ethernet/stmicro/stmmac/Makefile | 3 +- > drivers/net/ethernet/stmicro/stmmac/common.h | 2 + > .../net/ethernet/stmicro/stmmac/dw25gmac.c | 173 ++++++ > .../net/ethernet/stmicro/stmmac/dw25gmac.h | 90 +++ > .../net/ethernet/stmicro/stmmac/dwmac-brcm.c | 530 ++++++++++++++++++ > .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 31 + > drivers/net/ethernet/stmicro/stmmac/hwif.c | 25 +- > drivers/net/ethernet/stmicro/stmmac/hwif.h | 1 + > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + > include/linux/stmmac.h | 50 ++ > 12 files changed, 922 insertions(+), 3 deletions(-) > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dw25gmac.c > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dw25gmac.h > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c > > -- > 2.34.1 >
Powered by blists - more mailing lists