netdev - Re: [PATCH net] net: dsa: microchip: fix PTP config failure when using multiple ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f80d7a6b-651f-4c00-a068-c0cba2ff7ca9@lunn.ch>
Date: Fri, 16 Aug 2024 23:01:53 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Martin Whitaker <foss@...tin-whitaker.me.uk>
Cc: netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
	Woojung.Huh@...rochip.com, ceggers@...i.de,
	arun.ramadoss@...rochip.com
Subject: Re: [PATCH net] net: dsa: microchip: fix PTP config failure when
 using multiple ports

On Fri, Aug 16, 2024 at 06:18:46PM +0100, Martin Whitaker wrote:
> On 15/08/2024 15:38, Andrew Lunn wrote:
> > On Thu, Aug 15, 2024 at 09:38:14AM +0100, Martin Whitaker wrote:
> > > When performing the port_hwtstamp_set operation, ptp_schedule_worker()
> > > will be called if hardware timestamoing is enabled on any of the ports.
> > > When using multiple ports for PTP, port_hwtstamp_set is executed for
> > > each port. When called for the first time ptp_schedule_worker() returns
> > > 0. On subsequent calls it returns 1, indicating the worker is already
> > > scheduled. Currently the ksz driver treats 1 as an error and fails to
> > > complete the port_hwtstamp_set operation, thus leaving the timestamping
> > > configuration for those ports unchanged.
> > > 
> > > This patch fixes this by ignoring the ptp_schedule_worker() return
> > > value.
> > 
> > Hi Martin
> > 
> > Is this your first patch to netdev? Nicely done. A few minor
> > improvements. You have the correct tree, net, since this is a fix. You
> > should add a Fixes: tag indicating the patch which added the bug. And
> > also Cc: stable@...ble@...r.kernel.org
> > 
> > Thanks
> > 	Andrew
> 
> Hi Andrew,
> 
> It's my second patch. Yes, I missed the Fixes: tag. It should be
> 
> Fixes: bb01ad30570b0 ("net: dsa: microchip: ptp: manipulating absolute
> time using ptp hw clock")
> 
> Will you insert this, or do you need me to resend the patch?

Ideally, please resend it. patchwork might pickup the Fixes: tag from
your reply, but since it was wrapped, it might get it wrong. Sometimes
Jakub fixes things like this when merging patches, but it is easier
for him if there is a new correct version. And it is a good learning
exercise for somebody who i hope will submit more patches in the
future..

    Andrew