netdev - Re: [PATCH] SUNRPC: Fix -Wformat-truncation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <172384963142.6062.15815263849399206433@noble.neil.brown.name>
Date: Sat, 17 Aug 2024 09:07:11 +1000
From: "NeilBrown" <neilb@...e.de>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: kunwu.chan@...ux.dev, trondmy@...nel.org, anna@...nel.org,
 chuck.lever@...cle.com, jlayton@...nel.org, kolga@...app.com,
 Dai.Ngo@...cle.com, tom@...pey.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux-nfs@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Kunwu Chan" <chentao@...inos.cn>
Subject: Re: [PATCH] SUNRPC: Fix -Wformat-truncation warning

On Sat, 17 Aug 2024, Andrew Lunn wrote:
> On Wed, Aug 14, 2024 at 05:38:53PM +0800, kunwu.chan@...ux.dev wrote:
> > From: Kunwu Chan <chentao@...inos.cn>
> > 
> > Increase size of the servername array to avoid truncated output warning.
> > 
> > net/sunrpc/clnt.c:582:75: error：‘%s’ directive output may be truncated
> > writing up to 107 bytes into a region of size 48
> > [-Werror=format-truncation=]
> >   582 |                   snprintf(servername, sizeof(servername), "%s",
> >       |                                                             ^~
> > 
> > net/sunrpc/clnt.c:582:33: note:‘snprintf’ output
> > between 1 and 108 bytes into a destination of size 48
> >   582 |                     snprintf(servername, sizeof(servername), "%s",
> >       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   583 |                                          sun->sun_path);
> 
> I think this has come up before, but i could be mis-remembering.
> Please could you do a search for the discussion. The fact it is not
> solved suggests to me it is not so simple to fix. Maybe there is some
> protocol implications here.
> 
>        Andrew
> 

All I could find was 

 https://lore.kernel.org/all/1648103566-15528-1-git-send-email-baihaowen@meizu.com/

which essentially followed the same path as this conversation.  The
patch was resubmitted using UNIX_PATH_MAX but never responded to by the
relevant maintainers.

There are no protocol implications.  This string is only used for
informational messages.

NeilBrown