netdev - Re: [PATCH v1 net-next 0/2] net: Clean up af_ops->{get_link_af_size,fill_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240816023954.11958-1-kuniyu@amazon.com>
Date: Thu, 15 Aug 2024 19:39:54 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <razor@...ckwall.org>, <roopa@...dia.com>
Subject: Re: [PATCH v1 net-next 0/2] net: Clean up af_ops->{get_link_af_size,fill_link_af}().

From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 15 Aug 2024 18:36:51 -0700
> On Thu, 15 Aug 2024 14:11:35 -0700 Kuniyuki Iwashima wrote:
> > Since commit 5fa85a09390c ("net: core: rcu-ify rtnl af_ops"),
> > af_ops->{get_link_af_size,fill_link_af}() are called under RCU.
> > 
> > Patch 1 makes the context clear and patch 2 removes unnecessary
> > rcu_read_lock().
> 
> Tests violently disagree.
> 
> https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-08-16--00-00&pw-n=0&pass=0

Sorry, I missed the birdge one is called under RTNL.
I'll drop patch 2.