netdev - Re: [PATCH net-next] nfc: mrvl: use scoped device node handling to simplify cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1dd2de0-2263-4041-b494-70a1b3990143@kernel.org>
Date: Fri, 16 Aug 2024 07:11:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] nfc: mrvl: use scoped device node handling to
 simplify cleanup

On 16/08/2024 04:08, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 12:39:04 +0200 Krzysztof Kozlowski wrote:
>> -	matched_node = of_get_compatible_child(node, "marvell,nfc-uart");
>> +	struct device_node *matched_node __free(device_node) = of_get_compatible_child(node,
>> +										       "marvell,nfc-uart");
> 
> The 100+ character line mixing declaration and code is more than 
> I can bear. Sorry.

If by mixing you mean declaration not on top of the code, that's the
preferred style for __free() usage, as expressed by Linus. Constructor
and destructor in one place.

The 100 line, can be solved with wrapping after '=', but of course it is
not particularly pretty.

Let's drop the patch then.

Best regards,
Krzysztof