netdev - Re: [PATCH net-next v2] l2tp: use skb_queue_purge in l2tp_ip_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8362db69-ba48-56fc-5995-4195b00a2b9f@katalix.com>
Date: Fri, 16 Aug 2024 09:02:03 +0100
From: James Chapman <jchapman@...alix.com>
To: netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, dsahern@...nel.org, tparkin@...alix.com,
 xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next v2] l2tp: use skb_queue_purge in
 l2tp_ip_destroy_sock

On 15/08/2024 08:43, James Chapman wrote:
> Recent commit ed8ebee6def7 ("l2tp: have l2tp_ip_destroy_sock use
> ip_flush_pending_frames") was incorrect in that l2tp_ip does not use
> socket cork and ip_flush_pending_frames is for sockets that do. Use
> skb_queue_purge instead and remove the unnecessary lock.
> 
> Also unexport ip_flush_pending_frames since it was originally exported
> in commit 4ff8863419cd ("ipv4: export ip_flush_pending_frames") for
> l2tp and is not used by other modules.
> 
> ---
>    v2:
>      - also unexport ip_flush_pending_frames (cong)
>    v1: https://lore.kernel.org/all/20240813093914.501183-1-jchapman@katalix.com/
> 
> Suggested-by: xiyou.wangcong@...il.com
> Signed-off-by: James Chapman <jchapman@...alix.com>
> ---
>   net/ipv4/ip_output.c | 1 -
>   net/l2tp/l2tp_ip.c   | 4 +---
>   2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index 8a10a7c67834..b90d0f78ac80 100644


Gah, I notice tags are in the wrong place in the commit log. I'll send a v3.

--
pw-bot: cr