netdev - Re: [PATCH net-next] net: ovs: fix ovs_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816180104.3b843e93@kernel.org>
Date: Fri, 16 Aug 2024 18:01:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: pshelar@....org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, amorenoz@...hat.com, netdev@...r.kernel.org,
 dev@...nvswitch.org, linux-kernel@...r.kernel.org, Menglong Dong
 <dongml2@...natelecom.cn>
Subject: Re: [PATCH net-next] net: ovs: fix ovs_drop_reasons error

On Thu, 15 Aug 2024 20:22:45 +0800 Menglong Dong wrote:
> I'm sure if I understand it correctly, but it seems that there is
> something wrong with ovs_drop_reasons.
> 
> ovs_drop_reasons[0] is "OVS_DROP_LAST_ACTION", but
> OVS_DROP_LAST_ACTION == __OVS_DROP_REASON + 1, which means that
> ovs_drop_reasons[1] should be "OVS_DROP_LAST_ACTION".
> 
> Fix this by initializing ovs_drop_reasons with index.
> 
> Fixes: 9d802da40b7c ("net: openvswitch: add last-action drop reason")
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>

Could you include output? Presumably from drop monitor?
I think it should go to net rather than net-next.
-- 
pw-bot: cr