netdev - Re: [PATCH net-next 1/2] bonding: Add ESN support to IPSec HW offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408171959.Qj3TkV2v-lkp@intel.com>
Date: Sat, 17 Aug 2024 19:36:31 +0800
From: kernel test robot <lkp@...el.com>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Jay Vosburgh <j.vosburgh@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Tariq Toukan <tariqt@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
	Sabrina Dubroca <sd@...asysnail.net>,
	Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next 1/2] bonding: Add ESN support to IPSec HW offload

Hi Hangbin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/bonding-Add-ESN-support-to-IPSec-HW-offload/20240816-122016
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240816035518.203704-2-liuhangbin%40gmail.com
patch subject: [PATCH net-next 1/2] bonding: Add ESN support to IPSec HW offload
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20240817/202408171959.Qj3TkV2v-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240817/202408171959.Qj3TkV2v-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408171959.Qj3TkV2v-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/bonding/bond_main.c: In function 'bond_advance_esn_state':
>> drivers/net/bonding/bond_main.c:639:28: warning: unused variable 'ipsec' [-Wunused-variable]
     639 |         struct bond_ipsec *ipsec;
         |                            ^~~~~


vim +/ipsec +639 drivers/net/bonding/bond_main.c

   631	
   632	/**
   633	 * bond_advance_esn_state - ESN support for IPSec HW offload
   634	 * @xs: pointer to transformer state struct
   635	 **/
   636	static void bond_advance_esn_state(struct xfrm_state *xs)
   637	{
   638		struct net_device *bond_dev = xs->xso.dev;
 > 639		struct bond_ipsec *ipsec;
   640		struct bonding *bond;
   641		struct slave *slave;
   642	
   643		if (!bond_dev)
   644			return;
   645	
   646		rcu_read_lock();
   647		bond = netdev_priv(bond_dev);
   648		slave = rcu_dereference(bond->curr_active_slave);
   649	
   650		if (!slave)
   651			goto out;
   652	
   653		if (!xs->xso.real_dev)
   654			goto out;
   655	
   656		WARN_ON(xs->xso.real_dev != slave->dev);
   657	
   658		if (!slave->dev->xfrmdev_ops ||
   659		    !slave->dev->xfrmdev_ops->xdo_dev_state_advance_esn) {
   660			slave_warn(bond_dev, slave->dev, "%s: no slave xdo_dev_state_advance_esn\n", __func__);
   661			goto out;
   662		}
   663	
   664		slave->dev->xfrmdev_ops->xdo_dev_state_advance_esn(xs);
   665	out:
   666		rcu_read_unlock();
   667	}
   668	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki