netdev - Re: [net-next v3 05/15] net: cavium/liquidio: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMdWSKzh6gAzcQWNO=PWr1oOqf=9dKnhncSgkY5fYcL4nTMdA@mail.gmail.com>
Date: Sat, 17 Aug 2024 09:27:14 -0700
From: Allen <allen.lkml@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, jes@...ined-monkey.org, kda@...ux-powerpc.org, 
	cai.huoqing@...ux.dev, dougmill@...ux.ibm.com, npiggin@...il.com, 
	christophe.leroy@...roup.eu, aneesh.kumar@...nel.org, 
	naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com, tlfalcon@...ux.ibm.com, 
	cooldavid@...ldavid.org, marcin.s.wojtas@...il.com, mlindner@...vell.com, 
	stephen@...workplumber.org, nbd@....name, sean.wang@...iatek.com, 
	Mark-MC.Lee@...iatek.com, lorenzo@...nel.org, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, borisp@...dia.com, 
	bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com, 
	louis.peens@...igine.com, richardcochran@...il.com, 
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-acenic@...site.dk, linux-net-drivers@....com, netdev@...r.kernel.org, 
	Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [net-next v3 05/15] net: cavium/liquidio: Convert tasklet API to
 new bottom half workqueue mechanism

> > > Hm. Let me give you an example of what I was hoping to see for this
> > > patch (in addition to your explanation of the API difference):
> > >
> > >  The conversion for oct_priv->droq_bh_work should be safe. While
> > >  the work is per adapter, the callback (octeon_droq_bh()) walks all
> > >  queues, and for each queue checks whether the oct->io_qmask.oq mask
> > >  has a bit set. In case of spurious scheduling of the work - none of
> > >  the bits should be set, making the callback a noop.
> >
> > Thank you. Really appreciate your patience and help.
> >
> > Would you prefer a new series/or update this patch with this
> > additional info and resend it.
>
> Just thinking from the perspective of getting the conversions merged,
> could you send out the drivers/net/ethernet conversions which don't
> include use of enable_and_queue_work() first? Those should be quick
> to review and marge. And then separately if you could send the rest
> with updated commit messages for each case that would be splendid

 Sure, let me send the series again with this driver dropped. We can
revisit drivers with enable_and_queue_work() later.

Thank you.

-- 
       - Allen