netdev - Re: [PATCH net v2] net: dsa: microchip: fix PTP config failure when using multiple ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb2f5335d2046bfd420699f3f94e22f66090b808.camel@microchip.com>
Date: Mon, 19 Aug 2024 02:40:05 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <netdev@...r.kernel.org>, <foss@...tin-whitaker.me.uk>
CC: <stable@...r.kernel.org>, <Woojung.Huh@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, <ceggers@...i.de>, <andrew@...n.ch>
Subject: Re: [PATCH net v2] net: dsa: microchip: fix PTP config failure when
 using multiple ports

On Sat, 2024-08-17 at 10:41 +0100, Martin Whitaker wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> When performing the port_hwtstamp_set operation,
> ptp_schedule_worker()
> will be called if hardware timestamoing is enabled on any of the
> ports.
> When using multiple ports for PTP, port_hwtstamp_set is executed for
> each port. When called for the first time ptp_schedule_worker()
> returns
> 0. On subsequent calls it returns 1, indicating the worker is already
> scheduled. Currently the ksz driver treats 1 as an error and fails to
> complete the port_hwtstamp_set operation, thus leaving the
> timestamping
> configuration for those ports unchanged.
> 
> This patch fixes this by ignoring the ptp_schedule_worker() return
> value.
> 
> Link: 
> https://lore.kernel.org/netdev/7aae307a-35ca-4209-a850-7b2749d40f90@martin-whitaker.me.uk/
> Fixes: bb01ad30570b0 ("net: dsa: microchip: ptp: manipulating
> absolute time using ptp hw clock")
> Signed-off-by: Martin Whitaker <foss@...tin-whitaker.me.uk>

Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com>