netdev - Re: [PATCH net-next 0/9][pull request] idpf: XDP chapter II: convert Tx completion to libeth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33cd92d1-5d54-42d9-9e01-7c633543bfff@intel.com>
Date: Mon, 19 Aug 2024 13:58:40 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<przemyslaw.kitszel@...el.com>, <joshua.a.hay@...el.com>,
	<michal.kubiak@...el.com>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>
Subject: Re: [PATCH net-next 0/9][pull request] idpf: XDP chapter II: convert
 Tx completion to libeth

From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 15 Aug 2024 19:18:59 -0700

> On Wed, 14 Aug 2024 10:32:57 -0700 Tony Nguyen wrote:
>> Alexander Lobakin says:
>>
>> XDP for idpf is currently 5 chapters:
>> * convert Rx to libeth;
>> * convert Tx completion and stats to libeth (this);
>> * generic XDP and XSk code changes;
>> * actual XDP for idpf via libeth_xdp;
>> * XSk for idpf (^).
>>
>> Part II does the following:
>> * introduces generic libeth per-queue stats infra;
>> * adds generic libeth Tx completion routines;
>> * converts idpf to use generic libeth Tx comp routines;
>> * fixes Tx queue timeouts and robustifies Tx completion in general;
>> * fixes Tx event/descriptor flushes (writebacks);
>> * fully switches idpf per-queue stats to libeth.
>>
>> Most idpf patches again remove more lines than adds.
>> The perf difference is not visible by eye in common scenarios, but
>> the stats are now more complete and reliable, and also survive
>> ifups-ifdowns.
> 
> I'm tossing this.
> 
> Eric and Paolo are mostly AFK this month, I'm struggling to keep up
> and instead of helping review stuff you pile patches. That's not right.

I'll help with the reviews as well.

BTW can I send the netdev_feature_t to priv_flags conversion since
there's only one kdoc to fix and the rest was reviewed or should I wait
as well?

Thanks,
Olek