netdev - Re: [PATCH iwl-next v6 4/6] igb: Introduce XSK data structures and helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6bg8u50.fsf@kurt.kurt.home>
Date: Mon, 19 Aug 2024 16:27:55 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Richard Cochran
 <richardcochran@...il.com>, Sriram Yagnaraman
 <sriram.yagnaraman@...csson.com>, Benjamin Steinke
 <benjamin.steinke@...s-audio.com>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, bpf@...r.kernel.org, Sriram Yagnaraman
 <sriram.yagnaraman@....tech>
Subject: Re: [PATCH iwl-next v6 4/6] igb: Introduce XSK data structures and
 helpers

On Mon Aug 19 2024, Maciej Fijalkowski wrote:
> On Mon, Aug 19, 2024 at 03:41:20PM +0200, Kurt Kanzenbach wrote:
>> On Mon Aug 19 2024, Maciej Fijalkowski wrote:
>> > On Fri, Aug 16, 2024 at 11:24:03AM +0200, Kurt Kanzenbach wrote:
>> >> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
>> >> 
>> >> Add the following ring flag:
>> >> - IGB_RING_FLAG_TX_DISABLED (when xsk pool is being setup)
>> >> 
>> >> Add a xdp_buff array for use with XSK receive batch API, and a pointer
>> >> to xsk_pool in igb_adapter.
>> >> 
>> >> Add enable/disable functions for TX and RX rings.
>> >> Add enable/disable functions for XSK pool.
>> >> Add xsk wakeup function.
>> >> 
>> >> None of the above functionality will be active until
>> >> NETDEV_XDP_ACT_XSK_ZEROCOPY is advertised in netdev->xdp_features.
>> >> 
>> >> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
>> >
>> > Sriram's mail bounces unfortunately, is it possible to grab his current
>> > address?
>> 
>> His current email address is in the Cc list. However, i wasn't sure if
>> it's okay to update the From and SoB of these patches?
>
> Okay. Then I believe Sriram should provide a mailmap entry to map his old
> mail to a new one.
>
>> 
>> >
>> > You could also update the copyright date in igb_xsk.c.
>> 
>> Ditto for the copyright. It probably has to be something like
>> Copyright(c) 2023 Ericsson?
>
> It says 2018 Intel. I don't think Sriram was working under E/// employment
> as he said he was forbidden to work on this further and that's why you
> picked it up, right?
>
> My intent was not stir up the copyright pot, though. It can be left as-is
> or have something of a Linutronix/Sriram Yagnamaran mix :P

Let's see if Sriram has something to say about the copyright. If not
i'll just leave this as-is.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)