netdev - Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to configure fixed link state in phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <beeeb1f9-a194-4001-9cd0-f8045fb9e0e6@lunn.ch>
Date: Mon, 19 Aug 2024 18:08:50 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux@...linux.org.uk,
	kuba@...nel.org, horms@...nel.org, hkallweit1@...il.com,
	richardcochran@...il.com, rdunlap@...radead.org,
	Bryan.Whitehead@...rochip.com, edumazet@...gle.com,
	pabeni@...hat.com, linux-kernel@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
 configure fixed link state in phylink

> +/**
> + * phylink_set_fixed_link() - set the fixed link
> + * @pl: a pointer to a &struct phylink returned from phylink_create()
> + * @state: a pointer to a struct phylink_link_state.
> + *
> + * This function is used when the link parameters are known and do not change,
> + * making it suitable for certain types of network connections.
> + *
> + * Returns zero on success, or negative error code.

kernel doc requires a : after Returns. The tooling is getting more
picky about this and pointing out this error. But there is a lot of
code which gets this wrong, so you probably cut/paste a bad example.

    Andrew

---
pw-bot: cr