netdev - Re: [PATCH net-next v3] l2tp: use skb_queue_purge in l2tp_ip_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsLRUBb/+E+ygTxS@pop-os.localdomain>
Date: Sun, 18 Aug 2024 22:00:00 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
	tparkin@...alix.com
Subject: Re: [PATCH net-next v3] l2tp: use skb_queue_purge in
 l2tp_ip_destroy_sock

On Fri, Aug 16, 2024 at 09:07:51AM +0100, James Chapman wrote:
> Recent commit ed8ebee6def7 ("l2tp: have l2tp_ip_destroy_sock use
> ip_flush_pending_frames") was incorrect in that l2tp_ip does not use
> socket cork and ip_flush_pending_frames is for sockets that do. Use
> skb_queue_purge instead and remove the unnecessary lock.
> 
> Also unexport ip_flush_pending_frames since it was originally exported
> in commit 4ff8863419cd ("ipv4: export ip_flush_pending_frames") for
> l2tp and is not used by other modules.
> 
> Suggested-by: xiyou.wangcong@...il.com
> Signed-off-by: James Chapman <jchapman@...alix.com>

Reviewed-by: Cong Wang <cong.wang@...edance.com>

Thanks.