netdev - Re: [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cd98213-9111-4100-a8fa-15bb8292cbb5@microchip.com>
Date: Mon, 19 Aug 2024 06:53:51 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <kuba@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<horms@...nel.org>, <saeedm@...dia.com>, <anthony.l.nguyen@...el.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andrew@...n.ch>,
	<corbet@....net>, <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
	<ruanjinjie@...wei.com>, <Steen.Hegelund@...rochip.com>,
	<vladimir.oltean@....com>, <masahiroy@...nel.org>, <alexanderduyck@...com>,
	<krzk+dt@...nel.org>, <robh@...nel.org>, <rdunlap@...radead.org>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>,
	<Pier.Beruto@...emi.com>, <Selvamani.Rajagopal@...emi.com>,
	<Nicolas.Ferre@...rochip.com>, <benjamin.bigler@...nformulastudent.ch>,
	<linux@...ler.io>, <markku.vorne@...power.com>
Subject: Re: [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement
 receive path to receive rx ethernet frames

Hi Jakub,

Thanks for reviewing the patches.

On 16/08/24 10:31 pm, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, 12 Aug 2024 15:56:07 +0530 Parthiban Veerasooran wrote:
>> +     if (netif_rx(tc6->rx_skb) == NET_RX_DROP)
>> +             tc6->netdev->stats.rx_dropped++;
> 
> This is a bit unusual. If the core decides to drop the packet it will
> count the drop towards the appropriate statistic. The drivers generally
> only count their own drops, and call netif_rx() without checking the
> return value.
The first version of this patch series didn't have this check. There was 
a comment in the 1st version to check the return value and update the 
statistics.

https://lore.kernel.org/lkml/375fa9b4-0fb8-8d4b-8cb5-d8a9240d8f16@huawei.com/

That was the reason why it was introduced in the v2 of the patch series 
itself. It seems, somehow it got escaped from your RADAR from v2 to v5 
:D. Sorry, somehow I also missed to check it in the netdev core. Now I 
understand that the rx drop handled in the core itself in the below link 
using the function "dev_core_stats_rx_dropped_inc(skb->dev)".

https://github.com/torvalds/linux/blob/master/net/core/dev.c#L4894

Is my understanding correct? if so then I will remove this check in the 
next version.

Best regards,
Parthiban V