netdev - Re: [PATCH net v1] mlxbf_gige: disable port during stop()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240819174722.7701fa3c@kernel.org>
Date: Mon, 19 Aug 2024 17:47:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Thompson <davthompson@...dia.com>
Cc: Benjamin Poirier <benjamin.poirier@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, andriy.shevchenko@...ux.intel.com,
 u.kleine-koenig@...gutronix.de, asmaa@...dia.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v1] mlxbf_gige: disable port during stop()

On Mon, 19 Aug 2024 14:55:12 -0400 Benjamin Poirier wrote:
> Is this memory barrier paired with another one?

+1 
You probably want synchronize_irq() here?
You should explain in the cover letter, the mb() seems to not be
mentioned.
-- 
pw-bot: cr