netdev - Re: [PATCH iwl-net v3] ice: Add netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5e08b9f-9424-4863-b5f5-09d11c8a1dc7@linux.intel.com>
Date: Tue, 20 Aug 2024 12:18:07 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: netdev@...r.kernel.org, larysa.zaremba@...el.com,
 maciej.fijalkowski@...el.com, kalesh-anakkur.purayil@...adcom.com,
 Jakub Kicinski <kuba@...nel.org>, intel-wired-lan@...ts.osuosl.org,
 Igor Bagnucki <igor.bagnucki@...el.com>
Subject: Re: [PATCH iwl-net v3] ice: Add netif_device_attach/detach into PF
 reset flow

On 19.08.2024 10:47, Przemek Kitszel wrote:
> On 8/19/24 10:21, Dawid Osuchowski wrote:
>> @@ -7731,6 +7733,10 @@ static void ice_rebuild(struct ice_pf *pf, enum 
>> ice_reset_req reset_type)
>>           ice_rebuild_arfs(pf);
>>       }
>> +    struct ice_vsi *vsi = ice_get_main_vsi(pf);
> 
> you should separate declaration statements from expressions by one blank
> line; we also put declarations at the very front of the scope

Will fix in next revision, thanks.

>> +    if (vsi && vsi->netdev)
>> +        netif_device_attach(vsi->netdev);
>> +
>>       ice_update_pf_netdev_link(pf);
>>       /* tell the firmware we are up */
>