netdev - Re: [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsPqS6oFNpRmadxZ@Laptop-X1>
Date: Tue, 20 Aug 2024 08:58:51 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: Re: [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs?

Hi Jakub,
On Mon, Aug 19, 2024 at 05:22:32PM -0700, Jakub Kicinski wrote:
> On Tue, 20 Aug 2024 07:39:08 +0800 Hangbin Liu wrote:
> > Yesterday I tried to build the kernel with CONFIG_XFRM_OFFLOAD=y via `vng`[1],
> > but the result .config actually doesn't contain CONFIG_XFRM_OFFLOAD=y. I saw
> > XFRM_OFFLOAD in net/xfrm/Kconfig doesn't has any dependences. Do you know if
> > I missed something?
> 
> It's a hidden config option, not directly controlled by the user.
> You should enable INET_ESP_OFFLOAD and INET6_ESP_OFFLOAD instead
> (which "select" it)

Thanks for your reply. How to know if an option is hide other than review all
`make menuconfig` result?

Should we add a "depends on" for XFRM_OFFLOAD?

Regards
Hangbin