netdev - Re: [PATCH net] dpaa2-switch: Fix error checking in dpaa2_switch_seed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6jrlnhkyjpiyodoycu34bhwnltexwhcqz3idtxb2v4kmpugxyw@dsaul6pbszl7>
Date: Tue, 20 Aug 2024 15:33:24 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <vladimir.oltean@....com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] dpaa2-switch: Fix error checking in
 dpaa2_switch_seed_bp()

On Sat, Aug 17, 2024 at 09:52:46AM +0300, Dan Carpenter wrote:
> The dpaa2_switch_add_bufs() function returns the number of bufs that it
> was able to add.  It returns BUFS_PER_CMD (7) for complete success or a
> smaller number if there are not enough pages available.  However, the
> error checking is looking at the total number of bufs instead of the
> number which were added on this iteration.  Thus the error checking
> only works correctly for the first iteration through the loop and
> subsequent iterations are always counted as a success.
> 
> Fix this by checking only the bufs added in the current iteration.
> 
> Fixes: 0b1b71370458 ("staging: dpaa2-switch: handle Rx path on control interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Ioana Ciornei <ioana.ciornei@....com>
Tested-by: Ioana Ciornei <ioana.ciornei@....com>

Thanks,
Ioana