netdev - Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78332215-9b8a-4000-9c5d-98e13f664e67@intel.com>
Date: Tue, 20 Aug 2024 15:12:00 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Felix Fietkau <nbd@....name>
CC: <netdev@...r.kernel.org>
Subject: Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO_SOFTWARE

From: Felix Fietkau <nbd@....name>
Date: Fri, 16 Aug 2024 09:59:15 +0200

Please use scripts/get_maintainer.pl next time. I remember it was me who
added fraglist to GSO_SOFTWARE, but I'm not Cced =\

> Several drivers set NETIF_F_GSO_SOFTWARE, but mangle fraglist GRO packets

Which ones precisely?

> in a way that they can't be properly segmented anymore.
> In order to properly deal with this, remove fraglist GSO from
> NETIF_F_GSO_SOFTWARE and switch to NETIF_F_GSO_SOFTWARE_ALL (which includes
> fraglist GSO) in places where it's safe to add.

Why isn't bridge changed? It's only a software layer, I don't think it
break fraglist skbs anyhow.

> 
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  drivers/net/dummy.c                  | 2 +-
>  drivers/net/loopback.c               | 2 +-
>  drivers/net/macvlan.c                | 2 +-
>  include/linux/netdev_features.h      | 5 +++--
>  net/8021q/vlan.h                     | 2 +-
>  net/8021q/vlan_dev.c                 | 4 ++--
>  net/core/sock.c                      | 2 +-
>  net/mac80211/ieee80211_i.h           | 2 +-
>  net/openvswitch/vport-internal_dev.c | 2 +-
>  9 files changed, 12 insertions(+), 11 deletions(-)

Thanks,
Olek