netdev - Re: [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsPw2W8nLR4azKLo@Laptop-X1>
Date: Tue, 20 Aug 2024 09:26:49 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: Re: [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs?

On Mon, Aug 19, 2024 at 06:05:25PM -0700, Jakub Kicinski wrote:
> On Tue, 20 Aug 2024 08:58:51 +0800 Hangbin Liu wrote:
> > > It's a hidden config option, not directly controlled by the user.
> > > You should enable INET_ESP_OFFLOAD and INET6_ESP_OFFLOAD instead
> > > (which "select" it)  
> > 
> > Thanks for your reply. How to know if an option is hide other than review all
> > `make menuconfig` result?
> 
> If it has no description after bool or tristate -- it will be hidden

Appreciate, another tips learned.

> 
> > Should we add a "depends on" for XFRM_OFFLOAD?
> 
> You need it in bonding? You should use select (but not that select

Yes, I may write some xfrm offload tests for bonding.

> doesn't resolve dependencies, it only enables that single option).

I didn't get which "select" you mean here. Since INET_ESP_OFFLOAD will select
XFRM_OFFLOAD, Isn't adding

CONFIG_INET_ESP=y
CONFIG_INET_ESP_OFFLOAD=y

in tools/testing/selftests/drivers/net/bonding/config enough?

Thanks
Hangbin