netdev - Re: [PATCH net-next v2 2/9] bnxt_en: add support for retrieving crash dump using ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240819184140.1d38b98a@kernel.org>
Date: Mon, 19 Aug 2024 18:41:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Michael Chan <michael.chan@...adcom.com>, <netdev@...r.kernel.org>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, <pavan.chebbi@...adcom.com>,
 <andrew.gospodarek@...adcom.com>, <horms@...nel.org>, <helgaas@...nel.org>,
 Vikas Gupta <vikas.gupta@...adcom.com>, Somnath Kotur
 <somnath.kotur@...adcom.com>, <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 2/9] bnxt_en: add support for retrieving
 crash dump using ethtool

On Mon, 19 Aug 2024 12:12:39 +0200 Przemek Kitszel wrote:
> > +	if (dump_type == BNXT_DUMP_CRASH &&
> > +	    bp->fw_dbg_cap & DBG_QCAPS_RESP_FLAGS_CRASHDUMP_HOST_DDR &&  
> 
> I would wrap bitwise-and with parenthesis, even if not mandated by the C
> standard (the same in other places with combined expressions).

Personal preference, I guess. I generally lean on the side of limiting
the brackets.

👍️ to other comments, thank for reviewing!