netdev - Re: [PATCH v2 net 2/3] ipv6: fix possible UAF in ip6_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3999792-2613-4dd8-8337-db79273b3112@kernel.org>
Date: Tue, 20 Aug 2024 12:58:25 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Vasily Averin <vasily.averin@...ux.dev>
Subject: Re: [PATCH v2 net 2/3] ipv6: fix possible UAF in ip6_finish_output2()

On 8/20/24 10:08 AM, Eric Dumazet wrote:
> If skb_expand_head() returns NULL, skb has been freed
> and associated dst/idev could also have been freed.
> 
> We need to hold rcu_read_lock() to make sure the dst and
> associated idev are alive.
> 
> Fixes: 5796015fa968 ("ipv6: allocate enough headroom in ip6_finish_output2()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Vasily Averin <vasily.averin@...ux.dev>
> ---
>  net/ipv6/ip6_output.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>