netdev - Re: [PATCH v2] cxgb4: add forgotten u64 ivlan cast before shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240820154450.4a37077e@kernel.org>
Date: Tue, 20 Aug 2024 15:44:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Nikolay Kuratov <kniv@...dex-team.ru>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 stable@...r.kernel.org, lvc-project@...uxtesting.org, Kumar Sanghvi
 <kumaras@...lsio.com>, Potnuri Bharat Teja <bharat@...lsio.com>, Rahul
 Lakkireddy <rahul.lakkireddy@...lsio.com>, Ganesh Goudar
 <ganeshgr@...lsio.com>, "David S. Miller" <davem@...emloft.net>, Simon
 Horman <horms@...nel.org>
Subject: Re: [PATCH v2] cxgb4: add forgotten u64 ivlan cast before shift

On Mon, 19 Aug 2024 10:54:08 +0300 Nikolay Kuratov wrote:
> It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match()
> There is no reason it should not be done here

The max value of the shift is 21. I wish you spent more than 5 min
looking at this code.