netdev - Re: [PATCH bpf-next] bpf: use kfunc hooks instead of program types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKYLu4gW95gK=kbFUCT+vCZtb595vdd5jVNVzcLn7qsiw@mail.gmail.com>
Date: Tue, 20 Aug 2024 08:34:23 +0200
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Matteo Croce <technoboy85@...il.com>
Cc: bpf <bpf@...r.kernel.org>, Jonathan Corbet <corbet@....net>, Jiri Kosina <jikos@...nel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Matt Bobrowski <mattbobrowski@...gle.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Masami Hiramatsu <mhiramat@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	David Ahern <dsahern@...nel.org>, Pablo Neira Ayuso <pablo@...filter.org>, 
	Jozsef Kadlecsik <kadlec@...filter.org>, Steffen Klassert <steffen.klassert@...unet.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, Shuah Khan <shuah@...nel.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, 
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>, Linux-Fsdevel <linux-fsdevel@...r.kernel.org>, 
	fsverity@...ts.linux.dev, 
	"open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>, 
	linux-trace-kernel <linux-trace-kernel@...r.kernel.org>, 
	Network Development <netdev@...r.kernel.org>, netfilter-devel <netfilter-devel@...r.kernel.org>, 
	coreteam@...filter.org, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	Matteo Croce <teknoraver@...a.com>
Subject: Re: [PATCH bpf-next] bpf: use kfunc hooks instead of program types

On Tue, Aug 20, 2024 at 2:03 AM Matteo Croce <technoboy85@...il.com> wrote:
>
> From: Matteo Croce <teknoraver@...a.com>
>
> Pass to register_btf_kfunc_id_set() a btf_kfunc_hook directly, instead
> of a bpf_prog_type.
> Many program types share the same kfunc hook, so some calls to
> register_btf_kfunc_id_set() can be removed.
>
> Tested compiling the kernel with -Werror=enum-conversion to catch all
> the occourrences.
>
> Signed-off-by: Matteo Croce <teknoraver@...a.com>

I think it's too soon to do this kind of cleanup.
We need to refactor this logic to accommodate sched-ext
allow/deny pattern for kfunc per struct-ops hook.
Let's keep this code as-is for now.
pw-bot: cr