netdev - Re: [PATCH 4/9] block: mtip32xx: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e406ba06180571564b47872f090623b19e4ad87e.camel@redhat.com>
Date: Tue, 20 Aug 2024 09:29:52 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: onathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>, Wu Hao
 <hao.wu@...el.com>, Tom Rix <trix@...hat.com>, Moritz Fischer
 <mdf@...nel.org>,  Xu Yilun <yilun.xu@...el.com>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Alvaro Karsz <alvaro.karsz@...id-run.com>, "Michael
 S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>,  Eugenio Pérez
 <eperezma@...hat.com>, Richard Cochran <richardcochran@...il.com>, Mark
 Brown <broonie@...nel.org>, David Lechner <dlechner@...libre.com>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Jonathan
 Cameron <Jonathan.Cameron@...wei.com>,  Hannes Reinecke <hare@...e.de>,
 Damien Le Moal <dlemoal@...nel.org>, Chaitanya Kulkarni <kch@...dia.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>, 
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-block@...r.kernel.org, linux-fpga@...r.kernel.org, 
 linux-gpio@...r.kernel.org, netdev@...r.kernel.org, 
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org,  linux-pci@...r.kernel.org,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH 4/9] block: mtip32xx: Replace deprecated PCI functions

On Mon, 2024-08-19 at 21:04 +0300, Andy Shevchenko wrote:
> On Mon, Aug 19, 2024 at 06:51:44PM +0200, Philipp Stanner wrote:
> > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by
> > the
> > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> > 
> > In mtip32xx, these functions can easily be replaced by their
> > respective
> > successors, pcim_request_region() and pcim_iomap(). Moreover, the
> > driver's call to pcim_iounmap_regions() is not necessary, because
> > it's
> > invoked in the remove() function. Cleanup can, hence, be performed
> > by
> > PCI devres automatically.
> > 
> > Replace pcim_iomap_regions() and pcim_iomap_table().
> > 
> > Remove the call to pcim_iounmap_regions().
> 
> ...
> 
> int mtip_pci_probe()
> 
> >  setmask_err:
> > -	pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> > +	pcim_release_region(pdev, MTIP_ABAR);
> 
> But why?

EMOREINFOREQUIRED
Why I replace it or why I don't remove it completely?

> 
> ...
> 
> mtip_pci_remove()
> 
> >  	pci_disable_msi(pdev);
> >  
> > -	pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> 
> This is okay.

Removing it is okay, you mean.

> 
> ...
> 
> >  	pci_set_drvdata(pdev, NULL);
> 
> Side note: This is done by driver core for the last 10+ years…

Ah you know Andy, kernel programmers be like: "When you're hunting you
better make sure the wild sow is really dead before you load it in your
trunk" ;p

P.

>