netdev - Re: [PATCH net-next 06/12] ipv4: ipmr: Unmask upper DSCP bits in ipmr_rt_fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsYCIwtVxvRhzJs/@debian>
Date: Wed, 21 Aug 2024 17:05:07 +0200
From: Guillaume Nault <gnault@...hat.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, edumazet@...gle.com, dsahern@...nel.org,
	fw@...len.de, martin.lau@...ux.dev, daniel@...earbox.net,
	john.fastabend@...il.com, ast@...nel.org, pablo@...filter.org,
	kadlec@...filter.org, willemdebruijn.kernel@...il.com,
	bpf@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org
Subject: Re: [PATCH net-next 06/12] ipv4: ipmr: Unmask upper DSCP bits in
 ipmr_rt_fib_lookup()

On Wed, Aug 21, 2024 at 03:52:45PM +0300, Ido Schimmel wrote:
> Unmask the upper DSCP bits when calling ipmr_fib_lookup() so that in the
> future it could perform the FIB lookup according to the full DSCP value.
> 
> Note that ipmr_fib_lookup() performs a FIB rule lookup (returning the
> relevant routing table) and that IPv4 multicast FIB rules do not support
> matching on TOS / DSCP. However, it is still worth unmasking the upper
> DSCP bits in case support for DSCP matching is ever added.

Indeed,

Reviewed-by: Guillaume Nault <gnault@...hat.com>