netdev - Re: lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0aab2158-c8a0-493e-8a32-e1abd6ba6c1c@intel.com>
Date: Wed, 21 Aug 2024 12:12:00 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Vladimir Oltean <olteanv@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: lib/packing.c behaving weird if buffer length is not multiple of
 4 with QUIRK_LSW32_IS_FIRST



On 8/21/2024 6:58 AM, Vladimir Oltean wrote:
> On Mon, Aug 19, 2024 at 02:53:34PM -0700, Jacob Keller wrote:
>> The patches work for my use-case! I also think it might be helpful to
>> add some Kunit tests to cover the packing and unpacking, which I
>> wouldn't mind trying to do.
>>
>> If/when you send the patches, feel free to add:
>>
>> Tested-by: Jacob Keller <jacob.e.keller@...el.com>
>>
>> Alternatively, I could send them as part of the series where I implement
>> the changes to use lib/packing in the ice driver.
> 
> This is good to hear!
> 
> I did have some boot-time selftests written, albeit in a very bare-bones
> format. I'm afraid I do not have as much energy as I'd wish to push this
> patch set forward. Especially not to learn to use KUnit and to adapt the
> tests to that format.

No problem. I'm quite happy to work on that part.

> 
> If you wish, here is a Github branch with what I have. You can pick from
> it for your submissions and adapt as you see fit.
> https://github.com/vladimiroltean/linux/tree/packing-selftests

Ok. I'll investigate this, and I will send the two fixes for lib/packing
in my series to implement the support in ice. That would help on our end
with managing the changes since it avoids an interdependence between
multiple series in flight.

Regards,
Jake