netdev - Re: [PATCH net-next v5] net: netconsole: selftests: Create a new netconsole selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsWeHpPZxUh3I1Op@gmail.com>
Date: Wed, 21 Aug 2024 00:58:22 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	liuhangbin@...il.com, petrm@...dia.com, matttbe@...nel.org,
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
	Willem de Bruijn <willemb@...gle.com>, David Wei <dw@...idwei.uk>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next v5] net: netconsole: selftests: Create a new
 netconsole selftest

Hello Jakub,

On Tue, Aug 20, 2024 at 04:06:36PM -0700, Jakub Kicinski wrote:
> > +# ========== #
> > +# Start here #
> > +# ========== #
> > +modprobe netdevsim 2> /dev/null || true
> > +modprobe netconsole 2 > /dev/null || true

> Main reason Im complaining, I see:
> 
> [    6.686720] netconsole: unknown parameter '2' ignored
> 
> in the kernel logs when the test runs.
> 
> Is it expected?

It is not, the reason is the space above in `modprobe netconsole 2` 

Let me update it. Thanks
--breno