netdev - Re: [PATCH iwl-net v4] ice: Add netif_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25c69f6d-bd04-429e-a1d5-c6985b6555bf@linux.intel.com>
Date: Wed, 21 Aug 2024 10:10:21 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 larysa.zaremba@...el.com, kalesh-anakkur.purayil@...adcom.com,
 Jakub Kicinski <kuba@...nel.org>, Igor Bagnucki <igor.bagnucki@...el.com>
Subject: Re: [PATCH iwl-net v4] ice: Add netif_device_attach/detach into PF
 reset flow

On 21.08.2024 08:22, Maciej Fijalkowski wrote:
> On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
>> @@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)
>>   {
>>   	struct device *dev = ice_pf_to_dev(pf);
>>   	struct ice_hw *hw = &pf->hw;
>> +	struct ice_vsi *vsi = ice_get_main_vsi(pf);
> 
> we have an unwritten rule that is called 'reverse christmas tree' which
> requires us to have declarations of variables sorted from longest to
> shortest.
> 
> 	struct ice_vsi *vsi = ice_get_main_vsi(pf);
> 	struct device *dev = ice_pf_to_dev(pf);
> 	struct ice_hw *hw = &pf->hw;
> 	bool dvm;
> 	int err;
>

My apologies, I was not aware of that unwritten rule. Will fix in next 
revision, thanks. Other than that, does the rest of the changes look 
okay to you?

--Dawid