netdev - Re: [PATCH v2 8/9] vdap: solidrun: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve13TpA+OdUbiehZORjbNEi9qjJK3bg=C5CscoC=G=f4Q@mail.gmail.com>
Date: Wed, 21 Aug 2024 11:19:30 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Jonathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>, Wu Hao <hao.wu@...el.com>, 
	Tom Rix <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>, 
	Andy Shevchenko <andy@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Alvaro Karsz <alvaro.karsz@...id-run.com>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Eugenio Pérez <eperezma@...hat.com>, 
	Richard Cochran <richardcochran@...il.com>, Mark Brown <broonie@...nel.org>, 
	David Lechner <dlechner@...libre.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Damien Le Moal <dlemoal@...nel.org>, Hannes Reinecke <hare@...e.de>, Keith Busch <kbusch@...nel.org>, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-fpga@...r.kernel.org, 
	linux-gpio@...r.kernel.org, netdev@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org, 
	virtualization@...ts.linux.dev
Subject: Re: [PATCH v2 8/9] vdap: solidrun: Replace deprecated PCI functions

On Wed, Aug 21, 2024 at 10:19 AM Philipp Stanner <pstanner@...hat.com> wrote:
>
> solidrun utilizes pcim_iomap_regions(), which has been deprecated by the
> PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()"), among other
> things because it forces usage of quite a complicated bitmask mechanism.
> The bitmask handling code can entirely be removed by replacing
> pcim_iomap_regions() and pcim_iomap_table().
>
> Replace pcim_iomap_regions() and pcim_iomap_table() with
> pci_iomap_region().

...

>  static int snet_open_vf_bar(struct pci_dev *pdev, struct snet *snet)
>  {
>         char name[50];
> -       int ret;
>
>         snprintf(name, sizeof(name), "snet[%s]-bar", pci_name(pdev));

Shouldn't this be also devm_kasprintf()?

>         /* Request and map BAR */
> -       ret = pcim_iomap_regions(pdev, BIT(snet->psnet->cfg.vf_bar), name);
> -       if (ret) {
> +       snet->bar = pcim_iomap_region(pdev, snet->psnet->cfg.vf_bar, name);
> +       if (IS_ERR(snet->bar)) {
>                 SNET_ERR(pdev, "Failed to request and map PCI BAR for a VF\n");
> -               return ret;
> +               return PTR_ERR(snet->bar);
>         }
>
> -       snet->bar = pcim_iomap_table(pdev)[snet->psnet->cfg.vf_bar];
> -
>         return 0;
>  }

-- 
With Best Regards,
Andy Shevchenko