netdev - Re: [PATCH] netem: fix return value if duplicate enqueue fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172420083178.1283142.17547445579493801272.git-patchwork-notify@kernel.org>
Date: Wed, 21 Aug 2024 00:40:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, markovicbudimir@...il.com, jhs@...atatu.com,
 xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, lansheng@...wei.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netem: fix return value if duplicate enqueue fails

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 19 Aug 2024 10:56:45 -0700 you wrote:
> There is a bug in netem_enqueue() introduced by
> commit 5845f706388a ("net: netem: fix skb length BUG_ON in __skb_to_sgvec")
> that can lead to a use-after-free.
> 
> This commit made netem_enqueue() always return NET_XMIT_SUCCESS
> when a packet is duplicated, which can cause the parent qdisc's q.qlen to be
> mistakenly incremented. When this happens qlen_notify() may be skipped on the
> parent during destruction, leaving a dangling pointer for some classful qdiscs
> like DRR.
> 
> [...]

Here is the summary with links:
  - netem: fix return value if duplicate enqueue fails
    https://git.kernel.org/netdev/net/c/c07ff8592d57

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html