netdev - RE: [PATCH v2 net-next 2/3] net: phy: tja11xx: replace "nxp,rmii-refclk-in" with "nxp,phy-output-refclk"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85107F19C846ABDB74849086888F2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 22 Aug 2024 09:37:11 +0000
From: Wei Fang <wei.fang@....com>
To: Conor Dooley <conor@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "andrew@...n.ch" <andrew@...n.ch>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "hkallweit1@...il.com"
	<hkallweit1@...il.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"Andrei Botila (OSS)" <andrei.botila@....nxp.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 2/3] net: phy: tja11xx: replace
 "nxp,rmii-refclk-in" with "nxp,phy-output-refclk"

> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: 2024年8月22日 16:47
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; andrew@...n.ch; f.fainelli@...il.com;
> hkallweit1@...il.com; linux@...linux.org.uk; Andrei Botila (OSS)
> <andrei.botila@....nxp.com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 net-next 2/3] net: phy: tja11xx: replace
> "nxp,rmii-refclk-in" with "nxp,phy-output-refclk"
> 
> On Thu, Aug 22, 2024 at 09:37:20AM +0800, Wei Fang wrote:
> > As the new property "nxp,phy-output-refclk" is added to instead of the
> > "nxp,rmii-refclk-in" property, so replace the "nxp,rmii-refclk-in"
> > property used in the driver with the "nxp,reverse-mode" property and
> > make slight modifications.
> 
> Can you explain what makes this backwards compatible please?
> 
It does not backward compatible, the related PHY nodes in DTS also
need to be updated. I have not seen "nxp,rmii-refclk-in" used in the
upstream. For nodes that do not use " nxp,rmii-refclk-in", they need
to be updated, but unfortunately I cannot confirm which DTS use
TJA11XX PHY, and there may be no relevant nodes in upstream DTS.

> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > ---
> > V2 changes:
> > 1. Changed the property name.
> > ---
> >  drivers/net/phy/nxp-tja11xx.c | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/phy/nxp-tja11xx.c
> > b/drivers/net/phy/nxp-tja11xx.c index 2c263ae44b4f..7aa0599c38c3
> > 100644
> > --- a/drivers/net/phy/nxp-tja11xx.c
> > +++ b/drivers/net/phy/nxp-tja11xx.c
> > @@ -78,8 +78,7 @@
> >  #define MII_COMMCFG			27
> >  #define MII_COMMCFG_AUTO_OP		BIT(15)
> >
> > -/* Configure REF_CLK as input in RMII mode */
> > -#define TJA110X_RMII_MODE_REFCLK_IN       BIT(0)
> > +#define TJA11XX_REVERSE_MODE		BIT(0)
> >
> >  struct tja11xx_priv {
> >  	char		*hwmon_name;
> > @@ -274,10 +273,10 @@ static int tja11xx_get_interface_mode(struct
> phy_device *phydev)
> >  		mii_mode = MII_CFG1_REVMII_MODE;
> >  		break;
> >  	case PHY_INTERFACE_MODE_RMII:
> > -		if (priv->flags & TJA110X_RMII_MODE_REFCLK_IN)
> > -			mii_mode = MII_CFG1_RMII_MODE_REFCLK_IN;
> > -		else
> > +		if (priv->flags & TJA11XX_REVERSE_MODE)
> >  			mii_mode = MII_CFG1_RMII_MODE_REFCLK_OUT;
> > +		else
> > +			mii_mode = MII_CFG1_RMII_MODE_REFCLK_IN;
> >  		break;
> >  	default:
> >  		return -EINVAL;
> > @@ -517,8 +516,8 @@ static int tja11xx_parse_dt(struct phy_device
> *phydev)
> >  	if (!IS_ENABLED(CONFIG_OF_MDIO))
> >  		return 0;
> >
> > -	if (of_property_read_bool(node, "nxp,rmii-refclk-in"))
> > -		priv->flags |= TJA110X_RMII_MODE_REFCLK_IN;
> > +	if (of_property_read_bool(node, "nxp,phy-output-refclk"))
> > +		priv->flags |= TJA11XX_REVERSE_MODE;
> >
> >  	return 0;
> >  }
> > --
> > 2.34.1
> >