netdev - Re: [PATCH v1] drivers:atlx:Use max macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f994754-2005-420d-9be4-33d7288bc811@vivo.com>
Date: Thu, 22 Aug 2024 17:40:28 +0800
From: Yang Ruibin <11162571@...o.com>
To: Chris Snook <chris.snook@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Stephen Rothwell <sfr@...b.auug.org.au>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:atlx:Use max macro

Sorry, please ignore this patch.
Because the corresponding header file is not included, there may be 
compilation errors.

在 2024/8/22 15:50, Yang Ruibin 写道:
> Instead of using the max() implementation of
> the ternary operator, use real macros.
>
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>   drivers/net/ethernet/atheros/atlx/atl2.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
> index fa9a4919f..3ff669e72 100644
> --- a/drivers/net/ethernet/atheros/atlx/atl2.c
> +++ b/drivers/net/ethernet/atheros/atlx/atl2.c
> @@ -2971,10 +2971,7 @@ static void atl2_check_options(struct atl2_adapter *adapter)
>   #endif
>   	/* init RXD Flow control value */
>   	adapter->hw.fc_rxd_hi = (adapter->rxd_ring_size / 8) * 7;
> -	adapter->hw.fc_rxd_lo = (ATL2_MIN_RXD_COUNT / 8) >
> -		(adapter->rxd_ring_size / 12) ? (ATL2_MIN_RXD_COUNT / 8) :
> -		(adapter->rxd_ring_size / 12);
> -
> +	adapter->hw.fc_rxd_lo = max(ATL2_MIN_RXD_COUNT / 8, adapter->rxd_ring_size / 12);
>   	/* Interrupt Moderate Timer */
>   	opt.type = range_option;
>   	opt.name = "Interrupt Moderate Timer";