netdev - Re: [PATCH net-next v3 1/3] tc: adjust network header after 2nd vlan push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6befca6-4f89-4d9c-b3eb-68e80da5c285@redhat.com>
Date: Thu, 22 Aug 2024 11:41:19 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Boris Sukholitko <boris.sukholitko@...adcom.com>, netdev@...r.kernel.org,
 Martin KaFai Lau <martin.lau@...ux.dev>,
 Daniel Borkmann <daniel@...earbox.net>,
 John Fastabend <john.fastabend@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Pravin B Shelar <pshelar@....org>, Jamal Hadi Salim <jhs@...atatu.com>,
 Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Shuah Khan <shuah@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 Pavel Begunkov <asml.silence@...il.com>,
 Mina Almasry <almasrymina@...gle.com>, Lorenzo Bianconi
 <lorenzo@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 David Howells <dhowells@...hat.com>, Liang Chen <liangchen.linux@...il.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 Ido Schimmel <idosch@...sch.org>
Cc: Ilya Lifshits <ilya.lifshits@...adcom.com>
Subject: Re: [PATCH net-next v3 1/3] tc: adjust network header after 2nd vlan
 push

On 8/19/24 13:06, Boris Sukholitko wrote:
> diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c
> index 22f4b1e8ade9..9e2dbde3cc29 100644
> --- a/net/sched/act_vlan.c
> +++ b/net/sched/act_vlan.c
> @@ -96,6 +96,7 @@ TC_INDIRECT_SCOPE int tcf_vlan_act(struct sk_buff *skb,
>   	if (skb_at_tc_ingress(skb))
>   		skb_pull_rcsum(skb, skb->mac_len);
>   
> +	skb_reset_mac_header(skb);

This should be:
	 skb_reset_mac_len(skb);
right?

I'm baffled by the fact that the self-tests looks still happy?!?

Thanks,

Paolo