netdev - Re: [PATCH] xfrm: add SA information to the offloaded packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADsK2K-kOv-w+ZGFUKfUgpSdcx0d8wX4GHkecg6=qy2gtgmNfA@mail.gmail.com>
Date: Thu, 22 Aug 2024 13:11:35 -0700
From: Feng Wang <wangfe@...gle.com>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: netdev@...r.kernel.org, antony.antony@...unet.com
Subject: Re: [PATCH] xfrm: add SA information to the offloaded packet

Hi Steffen,

I have added the reason why SA info is needed in the commit message.
The new patch is
https://patchwork.kernel.org/project/netdevbpf/patch/20240822200252.472298-1-wangfe@google.com/

Thanks for your review.

Feng


On Sun, Aug 18, 2024 at 11:06 PM Steffen Klassert
<steffen.klassert@...unet.com> wrote:
>
> On Mon, Aug 12, 2024 at 11:23:17AM -0700, Feng Wang wrote:
> > From: wangfe <wangfe@...gle.com>
> >
> > In packet offload mode, append Security Association (SA) information
> > to each packet, replicating the crypto offload implementation.
> > The XFRM_XMIT flag is set to enable packet to be returned immediately
> > from the validate_xmit_xfrm function, thus aligning with the existing
> > code path for packet offload mode.
>
> Please explain in the commit message _why_ we need that change.
>
> Thanks!