netdev - Re: [PATCH] net: dpaa:reduce number of synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLbLv0P_cw99MiXVjZ1N2xOqzTemPxFkhBgtoWHty7otQ@mail.gmail.com>
Date: Thu, 22 Aug 2024 08:14:15 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Xi Huang <xuiagnh@...il.com>
Cc: madalin.bucur@....com, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dpaa:reduce number of synchronize_net() calls

On Thu, Aug 22, 2024 at 5:32 AM Xi Huang <xuiagnh@...il.com> wrote:
>
> In the function dpaa_napi_del(), we execute the netif_napi_del()
> for each cpu, which is actually a high overhead operation
> because each call to netif_napi_del() contains a synchronize_net(),
> i.e. an RCU operation. In fact, it is only necessary to call
>  __netif_napi_del and use synchronize_net() once outside of the loop.
> like commit 2543a6000e,5198d545db.

Correct way of citing commits is to use 12+ chars of sha1 ("patch title") as in
commit 2543a6000e59 ("gro_cells: reduce number of synchronize_net() calls")

Quoting Documentation/dev-tools/checkpatch.rst :

  **GIT_COMMIT_ID**
    The proper way to reference a commit id is:
    commit <12+ chars of sha1> ("<title line>")

    An example may be::

      Commit e21d2170f36602ae2708 ("video: remove unnecessary
      platform_set_drvdata()") removed the unnecessary
      platform_set_drvdata(), but left the variable "dev" unused,
      delete it.

    See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes


> here is the function definition:
>  static inline void netif_napi_del(struct napi_struct * napi)
> {
>         __netif_napi_del(napi).
>         synchronize_net();
> }

You do not need to include netif_napi_del() in this changelog.

Please send a V2 in ~24 hours and add this :

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thank you.