netdev - Re: [PATCH ne]t-next net: netlink: Remove the dump_cb_mutex field from struct netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb0ac894-9e84-4628-b4cd-88d594eba2c5@wanadoo.fr>
Date: Thu, 22 Aug 2024 09:02:29 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH ne]t-next net: netlink: Remove the dump_cb_mutex field
 from struct netlink_sock

Le 22/08/2024 à 08:48, Christophe JAILLET a écrit :
> Commit 5fbf57a937f4 ("net: netlink: remove the cb_mutex "injection" from
> netlink core") has removed the usage of the 'dump_cb_mutex' field from the
> struct netlink_sock.
> 
> Remove the field itself now. It saves a few bytes in the structure.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>   net/netlink/af_netlink.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h
> index 9751e29d4bbb..5b0e4e62ab8b 100644
> --- a/net/netlink/af_netlink.h
> +++ b/net/netlink/af_netlink.h
> @@ -41,7 +41,6 @@ struct netlink_sock {
>   	struct netlink_callback	cb;
>   	struct mutex		nl_cb_mutex;
>   
> -	struct mutex		*dump_cb_mutex;
>   	void			(*netlink_rcv)(struct sk_buff *skb);
>   	int			(*netlink_bind)(struct net *net, int group);
>   	void			(*netlink_unbind)(struct net *net, int group);

Sorry for the broken subject, I'll resend.

CJ