netdev - Re: [PATCH net-next 00/10] net: Delete some redundant judgments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y14nidbs.fsf@nvidia.com>
Date: Fri, 23 Aug 2024 15:16:46 +0200
From: Petr Machata <petrm@...dia.com>
To: Li Zetao <lizetao1@...wei.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <dsahern@...nel.org>, <idosch@...dia.com>,
	<amcohen@...dia.com>, <petrm@...dia.com>, <gnault@...hat.com>,
	<b.galvani@...il.com>, <alce@...ranque.net>, <shaozhengchao@...wei.com>,
	<horms@...nel.org>, <j.granados@...sung.com>, <linux@...ssschuh.net>,
	<judyhsiao@...omium.org>, <jiri@...nulli.us>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 00/10] net: Delete some redundant judgments


Li Zetao <lizetao1@...wei.com> writes:

> This patchset aims to remove some unnecessary judgments and make the
> code more concise. In some network modules, rtnl_set_sk_err is used to
> record error information, but the err is repeatedly judged to be less
> than 0 on the error path. Deleted these redundant judgments.

What you call "judgments" would be usually called "conditionals" or
"conditional statements", "judged less than zero" would be probably
"compared to zero". I think the commit messages are reasonably clear
despite this, so I'd leave it be unless others push back. But it's worth
keeping in mind for future contributions.