netdev - Re: [PATCH net V6 0/3] Fixes for IPsec over bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <194957.1724445200@famine>
Date: Fri, 23 Aug 2024 13:33:20 -0700
From: Jay Vosburgh <jv@...sburgh.net>
To: Jianbo Liu <jianbol@...dia.com>
cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
    pabeni@...hat.com, edumazet@...gle.com, andy@...yhouse.net,
    saeedm@...dia.com, gal@...dia.com, leonro@...dia.com,
    liuhangbin@...il.com, tariqt@...dia.com
Subject: Re: [PATCH net V6 0/3] Fixes for IPsec over bonding

Jianbo Liu <jianbol@...dia.com> wrote:

>Hi,
>
>This patchset provides bug fixes for IPsec over bonding driver.
>
>It adds the missing xdo_dev_state_free API, and fixes "scheduling while
>atomic" by using mutex lock instead.
>
>Series generated against:
>commit c07ff8592d57 ("netem: fix return value if duplicate enqueue fails")
>
>Thanks!
>Jianbo

	I am not sufficiently familiar with the innards of IPsec to
comment on whether or not those aspects are correct, but the the other
changes look good to me.

	For the series:

Acked-by: Jay Vosburgh <jv@...sburgh.net>

	-J

>V6
>- Add netdev_hold/netdev_put to prevent real_dev from being freed for
>  bond_ipsec_add_sa, bond_ipsec_del_sa and bond_ipsec_free_sa.
>
>V5:
>- Rebased.
>- Removed state deletion/free in bond_ipsec_add_sa_all() added before,
>  as real_dev is not set to NULL in Nikolay's patch. 
>
>V4:
>- Add to all patches: Reviewed-by: Hangbin Liu <liuhangbin@...il.com>.
>- Update commit message in patch 1 (Jakub).
>
>V3:
>- Add RCU read lock/unlock for bond_ipsec_add_sa, bond_ipsec_del_sa and bond_ipsec_free_sa.
>
>V2:
>- Rebased on top of latest net branch.
>- Squashed patch #2 into #1 per Hangbin comment.
>- Addressed Hangbin's comments.
>- Patch #3 (was #4): Addressed comments by Paolo.
>
>Jianbo Liu (3):
>  bonding: implement xdo_dev_state_free and call it after deletion
>  bonding: extract the use of real_device into local variable
>  bonding: change ipsec_lock from spin lock to mutex
>
> drivers/net/bonding/bond_main.c | 159 +++++++++++++++++++++-----------
> include/net/bonding.h           |   2 +-
> 2 files changed, 106 insertions(+), 55 deletions(-)
>
>-- 
>2.21.0
>

---
	-Jay Vosburgh, jv@...sburgh.net