netdev - Re: [PATCHv4 net-next 0/3] Bonding: support new xfrm state offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <195355.1724446106@famine>
Date: Fri, 23 Aug 2024 13:48:26 -0700
From: Jay Vosburgh <jv@...sburgh.net>
To: Hangbin Liu <liuhangbin@...il.com>
cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
    Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
    Eric Dumazet <edumazet@...gle.com>,
    Nikolay Aleksandrov <razor@...ckwall.org>,
    Tariq Toukan <tariqt@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
    Sabrina Dubroca <sd@...asysnail.net>,
    Simon Horman <horms@...nel.org>,
    Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCHv4 net-next 0/3] Bonding: support new xfrm state offload
 functions

Hangbin Liu <liuhangbin@...il.com> wrote:

>Add 2 new xfrm state offload functions xdo_dev_state_advance_esn and
>xdo_dev_state_update_stats for bonding. The xdo_dev_state_free will be
>added by Jianbo's patchset [1]. I will add the bonding xfrm policy offload
>in future.

	These look ok to me from a code point of view, but I'm not
familiar enough with IPsec to comment on whether those aspects are
correct.  A cursory examiniation suggests that none of the new functions
being called might sleep.

	For the series:

Acked-by: Jay Vosburgh <jv@...sburgh.net>

	-J

>v4: Ratelimit pr_warn (Sabrina Dubroca)
>v3: Re-format bond_ipsec_dev, use slave_warn instead of WARN_ON (Nikolay Aleksandrov)
>    Fix bond_ipsec_dev defination, add *. (Simon Horman, kernel test robot)
>    Fix "real" typo (kernel test robot)
>v2: Add a function to process the common device checking (Nikolay Aleksandrov)
>    Remove unused variable (Simon Horman)
>v1: lore.kernel.org/netdev/20240816035518.203704-1-liuhangbin@...il.com
>
>Hangbin Liu (3):
>  bonding: add common function to check ipsec device
>  bonding: Add ESN support to IPSec HW offload
>  bonding: support xfrm state update
>
> drivers/net/bonding/bond_main.c | 97 ++++++++++++++++++++++++++++-----
> 1 file changed, 84 insertions(+), 13 deletions(-)
>
>-- 
>2.45.0

---
	-Jay Vosburgh, jv@...sburgh.net