netdev - Re: [PATCH net 1/1] tcp: check skb is non-NULL in tcp_rto_delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <759b06be-9fb8-4fc1-bc93-3f03b3665152@akamai.com>
Date: Thu, 22 Aug 2024 21:21:51 -0700
From: Josh Hunt <johunt@...mai.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: edumazet@...gle.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/1] tcp: check skb is non-NULL in tcp_rto_delta_us()

On 8/22/24 8:33 PM, Josh Hunt wrote:
> On 8/22/24 8:27 PM, Jason Xing wrote:
>>
>> Hello Josh,
>>
>> On Fri, Aug 23, 2024 at 11:02 AM Josh Hunt <johunt@...mai.com> wrote:
>>>
>>> There have been multiple occassions where we have crashed in this path
>>> because packets_out suggested there were packets on the write or 
>>> retransmit
>>> queues, but in fact there weren't leading to a NULL skb being 
>>> dereferenced.
>>
>> Could you show us the detailed splats and more information about it so
>> that we can know what exactly happened?
> 
> Hey Jason
> 
> Yeah for some reason my cover letter did not come through which has the 
> oops info that we hit. I'll resend it now. Fingers crossed it goes 
> through this time :)
> 
> Josh
Seems like our mail server is block the cover letter for some reason 
right now. I'll have to figure out why tomorrow. I filed a bug with 
Ubuntu as well as sending this patch upstream b/c the kernel we're 
running is a stock Ubuntu kernel. The bug report there has most of what 
I put in the cover letter:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2077657

Josh