netdev - Re: [PATCH -next 1/2] net/ipv4: fix macro definition sk_for_each_bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e771d82b-81d7-43c2-bc16-280598cc1c9a@huawei.com>
Date: Fri, 23 Aug 2024 14:54:02 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: <edumazet@...gle.com>, <davem@...emloft.net>, <dsahern@...nel.org>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>
Subject: Re: [PATCH -next 1/2] net/ipv4: fix macro definition
 sk_for_each_bound_bhash

Sorry, wrong subject, just ignore this.

Thanks,
Hongbo

On 2024/8/23 15:00, Hongbo Li wrote:
> The macro sk_for_each_bound_bhash accepts a parameter
> __sk, but it was not used, rather the sk2 is directly
> used, so we replace the sk2 with __sk in macro.
> 
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
>   net/ipv4/inet_connection_sock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index 64d07b842e73..ce4d77f49243 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -236,7 +236,7 @@ static bool inet_bhash2_conflict(const struct sock *sk,
>   
>   #define sk_for_each_bound_bhash(__sk, __tb2, __tb)			\
>   	hlist_for_each_entry(__tb2, &(__tb)->bhash2, bhash_node)	\
> -		sk_for_each_bound(sk2, &(__tb2)->owners)
> +		sk_for_each_bound((__sk), &(__tb2)->owners)
>   
>   /* This should be called only when the tb and tb2 hashbuckets' locks are held */
>   static int inet_csk_bind_conflict(const struct sock *sk,