netdev - Re: [PATCH v4 net-next 02/12] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8259922e-7a97-4b71-9127-0a403c3d4c9c@redhat.com>
Date: Fri, 23 Aug 2024 11:04:23 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
 Madhu Chittim <madhu.chittim@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Simon Horman <horms@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 Jamal Hadi Salim <jhs@...atatu.com>, Donald Hunter <donald.hunter@...il.com>
Subject: Re: [PATCH v4 net-next 02/12] netlink: spec: add shaper YAML spec

On 8/23/24 10:35, Paolo Abeni wrote:
> On 8/23/24 03:48, Jakub Kicinski wrote:
>> On Tue, 20 Aug 2024 17:12:23 +0200 Paolo Abeni wrote:
>>> +    render-max: true
>>> +    entries:
>>> +      - name: unspec
>>> +        doc: The scope is not specified.
>>> +      -
>>> +        name: netdev
>>> +        doc: The main shaper for the given network device.
>>> +      -
>>> +        name: queue
>>> +        doc: The shaper is attached to the given device queue.
>>> +      -
>>> +        name: node
>>> +        doc: |
>>> +             The shaper allows grouping of queues or others
>>> +             node shapers, is not attached to any user-visible
>>
>> Saying it's not attached is confusing. Makes it sound like it exists
>> outside of the scope of a struct net_device.
> 
> What about:
> 
>     Can be placed in any arbitrary location of
>     the scheduling tree, except leaves and root.

To rephrase the whole doc:

	     The shaper allows grouping of queues or others
              node shapers; can be nested to either @netdev
              shapers or other @node shapers, allowing placement
              in any arbitrary location of the scheduling tree,
              except leaves and root.

/P